fixed a issue that causes RuntimeError in Python 3#3
Merged
capoony merged 1 commit intocapoony:masterfrom Jul 28, 2021
Merged
Conversation
Owner
|
Hi Siyuan, awesome! Thanks a lot for spotting this. Cheers, Martin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Martin,
It's really appreciated that you've upgraded your code to Python 3, making it more compatible with the current environment.
Recently, my colleague reported a runtime error that is caused by changing dictionary size during iteration when running PoolSNP.py. This error won't corrupt the whole script or affect the result, but people might get nervous about an 'error' being raised. Thus, I add a '.copy()' to your line 232 to avoid this issue.
Interestingly, Python 2 won't report this runtime error when a dictionary size is changed during iteration, but Python 3 does. I also noticed you have added
.copy()to line 198 when filteringtotalallelesby mincount or minfreq, so you've probably realized this issue but forgot to modify the other line.