Add ANONYMIZE_IP env#2
Merged
Merged
Conversation
Contributor
|
Thanks! By the way, the linked code is no longer in caprover/caprover. The GoAccess image is this very repository! |
githubsaturn
reviewed
Dec 1, 2025
| else | ||
| # If anonymization is disabled but database has anonymization marker, remove it | ||
| if [ -d "$dbPath" ] && [ -f "$appPath/.anonymize-ip" ]; then | ||
| echo "Anonymization disabled but database was created with anonymization, removing to recreate" |
Contributor
There was a problem hiding this comment.
Since you're technically changing the current behavior, let's version up to make sure we don't cause issues for existing installs. Change version to 1.9.4 here:
Line 1 in 35fa79e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution to #1
It should work, however because of https://github.com/caprover/caprover/pull/2182/files#diff-be2d59703cc7a4531af0e468307ee11509b946fad11999b5e1241f2c5870028aR450 it needs to be possible to set it up from the UI, because the server creates a temporary instance each time the user wants to see new stats.
Manually changing the long-running instance will only work for cron jobs, not on-demand ones.