DIET MSVC C1001 Fix #2782
Merged
DIET MSVC C1001 Fix #2782
+61
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
What is the command you tested it with? Just so we see if it builds and runs some basic decoding well. |
This reverts commit fd12444.
Collaborator
|
I'll review it tomorrow. Please rebase in the meanwhile. |
Contributor
Author
|
Already rebased, all conflicts resolved |
Rot127
approved these changes
Sep 1, 2025
wargio
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Unable to compile applications using capstone with DIET define
Test plan
Compile any application using capstone with MSVC v143 and CAPSTONE_BUILD_DIET option in cmake
Closing issues
closes #2780