fix: Keep highlight when page is zoomed in/out#2
Merged
MauritsBrinkman merged 1 commit intocaptide-tech:mainfrom Jan 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents zoom-triggered PDF reloads and make highlight navigation optional. The document viewer no longer reloads the PDF when
zoomLevelchanges, and highlight creation now accepts an an option to suppress page navigation during highlight recreation. This keeps the viewer on the current page while still refreshing highlights after zoom. Changes are indocument-viewer.tsxandpdf-highlighting.ts.Summary:
zoomLevelfrom the render effect deps indocument-viewer.tsx.createRectangleHighlightto acceptshouldNavigateOnMatchand wire it from the viewer to avoid forced page jumps during highlight recreation.