Migrate installers to D&V action#52
Merged
Merged
Conversation
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
This reverts commit 72cd570.
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Member
Author
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors all installer GitHub Actions for Carabiner tools to use a single, centralized
download-and-verifyaction, improving maintainability and consistency of binary verification. It also introduces new configuration options for policy, context, and signers, and adds support for thepolicyctltool in the test workflow. Several tool versions are updated as well.Key changes include:
Installer Refactoring and Verification Pipeline:
All tool installer actions (
ampel,beaker,bnd,revex,snappy,policyctl) now delegate installation and verification to the shareddownload-and-verifyaction, replacing custom platform-detection and download logic with a unified, provenance-verified approach. This ensures consistent security and reduces code duplication. [1] [2] [3] [4] [5] [6]The
download-and-verifyaction now supports new inputs for specifying the verification policy, context, and signers, with sensible defaults that enhance provenance validation and flexibility for downstream workflows. [1] [2]Workflow and Tooling Updates:
The test workflow (
test-installers.yaml) is updated to includepolicyctlin the matrix and adds a new job to test downloading and verifying thesnappytool, further exercising the new verification logic. [1] [2] [3]Tool versions are updated for
beaker(tov0.1.2),revex(tov0.0.2), andsnappy(tov0.2.4), ensuring the workflow tests current releases. [1] [2] [3]Other Improvements:
These changes collectively improve the security, maintainability, and clarity of the installer workflows for all Carabiner CLI tools.
Closes #51
Supersedes #49