Skip to content

Migrate installers to D&V action#52

Merged
miniprow-dev[bot] merged 4 commits into
mainfrom
migrate-installers
May 6, 2026
Merged

Migrate installers to D&V action#52
miniprow-dev[bot] merged 4 commits into
mainfrom
migrate-installers

Conversation

@puerco

@puerco puerco commented May 5, 2026

Copy link
Copy Markdown
Member

This pull request refactors all installer GitHub Actions for Carabiner tools to use a single, centralized download-and-verify action, improving maintainability and consistency of binary verification. It also introduces new configuration options for policy, context, and signers, and adds support for the policyctl tool in the test workflow. Several tool versions are updated as well.

Key changes include:

Installer Refactoring and Verification Pipeline:

  • All tool installer actions (ampel, beaker, bnd, revex, snappy, policyctl) now delegate installation and verification to the shared download-and-verify action, replacing custom platform-detection and download logic with a unified, provenance-verified approach. This ensures consistent security and reduces code duplication. [1] [2] [3] [4] [5] [6]

  • The download-and-verify action now supports new inputs for specifying the verification policy, context, and signers, with sensible defaults that enhance provenance validation and flexibility for downstream workflows. [1] [2]

Workflow and Tooling Updates:

  • The test workflow (test-installers.yaml) is updated to include policyctl in the matrix and adds a new job to test downloading and verifying the snappy tool, further exercising the new verification logic. [1] [2] [3]

  • Tool versions are updated for beaker (to v0.1.2), revex (to v0.0.2), and snappy (to v0.2.4), ensuring the workflow tests current releases. [1] [2] [3]

Other Improvements:

  • Copyright years in installer action metadata are updated.
  • Descriptions in action metadata are clarified for several tools. [1] [2] [3] [4] [5]

These changes collectively improve the security, maintainability, and clarity of the installer workflows for all Carabiner CLI tools.

Closes #51
Supersedes #49

@miniprow-dev miniprow-dev Bot added lgtm Indicates that a PR is ready to be merged (Looks Good To Me) approved Indicates a PR has been approved by an approver from all required OWNERS files labels May 5, 2026
@puerco puerco force-pushed the migrate-installers branch from 8d15a21 to 72cd570 Compare May 5, 2026 21:36
@miniprow-dev miniprow-dev Bot added lgtm Indicates that a PR is ready to be merged (Looks Good To Me) and removed lgtm Indicates that a PR is ready to be merged (Looks Good To Me) labels May 5, 2026
@puerco puerco force-pushed the migrate-installers branch from 0d14052 to f819ce5 Compare May 5, 2026 22:56
@miniprow-dev miniprow-dev Bot added lgtm Indicates that a PR is ready to be merged (Looks Good To Me) and removed lgtm Indicates that a PR is ready to be merged (Looks Good To Me) labels May 5, 2026
@puerco puerco force-pushed the migrate-installers branch from f819ce5 to d87f110 Compare May 5, 2026 23:01
@miniprow-dev miniprow-dev Bot added lgtm Indicates that a PR is ready to be merged (Looks Good To Me) and removed lgtm Indicates that a PR is ready to be merged (Looks Good To Me) labels May 5, 2026
@puerco puerco force-pushed the migrate-installers branch from d87f110 to 20cabf1 Compare May 5, 2026 23:05
@miniprow-dev miniprow-dev Bot added lgtm Indicates that a PR is ready to be merged (Looks Good To Me) and removed lgtm Indicates that a PR is ready to be merged (Looks Good To Me) labels May 5, 2026
puerco added 3 commits May 5, 2026 17:23
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
@puerco puerco force-pushed the migrate-installers branch from 8bb674f to 6022a06 Compare May 5, 2026 23:28
@miniprow-dev miniprow-dev Bot added lgtm Indicates that a PR is ready to be merged (Looks Good To Me) and removed lgtm Indicates that a PR is ready to be merged (Looks Good To Me) labels May 5, 2026
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
@puerco puerco force-pushed the migrate-installers branch from 052b097 to f76aaf6 Compare May 5, 2026 23:57
@miniprow-dev miniprow-dev Bot added lgtm Indicates that a PR is ready to be merged (Looks Good To Me) and removed lgtm Indicates that a PR is ready to be merged (Looks Good To Me) labels May 5, 2026
@puerco puerco changed the title Migrate snappy installer to D&V action Migrate installers to D&V action May 5, 2026
@puerco

puerco commented May 6, 2026

Copy link
Copy Markdown
Member Author

/lgtm

@miniprow-dev miniprow-dev Bot added the lgtm Indicates that a PR is ready to be merged (Looks Good To Me) label May 6, 2026
@miniprow-dev miniprow-dev Bot merged commit 2a11d59 into main May 6, 2026
28 checks passed
@miniprow-dev miniprow-dev Bot deleted the migrate-installers branch May 6, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files lgtm Indicates that a PR is ready to be merged (Looks Good To Me)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install/ampel + install/bnd: curl downloads have no checksum/signature verification

1 participant