Skip to content

chore(helmchart): Remove db-migrations from mlp chart; migrations now run at app start up#62

Merged
maniteja6799 merged 3 commits into
mainfrom
remove-db-migrations
Sep 30, 2022
Merged

chore(helmchart): Remove db-migrations from mlp chart; migrations now run at app start up#62
maniteja6799 merged 3 commits into
mainfrom
remove-db-migrations

Conversation

@maniteja6799
Copy link
Copy Markdown
Collaborator

Motivation

Remove the Kube manifests and configurations related to db-migrations from the mlp chart. Since starting mlp:1.7.1 DB-migrations are running at app start up

Changes

  • Removed configMap loading db-migrations
  • remove init containers in mlp-deployment which run db-migrations
  • remove volume mounts for configMap wherever used.
  • Increment chart version
  • update mlp image tag to 1.7.2

Copy link
Copy Markdown
Collaborator

@romanwozniak romanwozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove [db-migrations](https://github.com/gojek/mlp/blob/main/charts/mlp/db-migrations) symlink

@maniteja6799 maniteja6799 merged commit 39d1f8b into main Sep 30, 2022
@maniteja6799 maniteja6799 deleted the remove-db-migrations branch September 30, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants