Skip to content

Update PageNavigation to use useNavigate hook#63

Merged
krithika369 merged 2 commits into
caraml-dev:mainfrom
krithika369:update_page_navigation_comp
Oct 18, 2022
Merged

Update PageNavigation to use useNavigate hook#63
krithika369 merged 2 commits into
caraml-dev:mainfrom
krithika369:update_page_navigation_comp

Conversation

@krithika369
Copy link
Copy Markdown
Collaborator

@krithika369 krithika369 commented Oct 17, 2022

Since the migration from @reach/router to react-router-dom in #56, this PR updates the last remaining component that's using the now invalid props.navigate to the useNavigate() hook.

Also removing the hasFocus property which is now no longer valid, from EuiContextMenuPanel.

@krithika369 krithika369 marked this pull request as draft October 17, 2022 10:18
@krithika369 krithika369 marked this pull request as ready for review October 18, 2022 00:24
@krithika369 krithika369 requested a review from a team October 18, 2022 00:25
Copy link
Copy Markdown
Collaborator

@romanwozniak romanwozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@krithika369 krithika369 merged commit efe5a1f into caraml-dev:main Oct 18, 2022
@krithika369 krithika369 deleted the update_page_navigation_comp branch October 18, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants