Update Go version + Remove outdated prop from MLP UI app#65
Merged
Conversation
added 2 commits
October 25, 2022 12:29
krithika369
changed the title
deadlycoconuts
approved these changes
Oct 25, 2022
Collaborator
deadlycoconuts
left a comment
deadlycoconuts
left a comment
There was a problem hiding this comment.
LGTM! 🚀 Thanks for updating this!
Collaborator
Author
|
Thanks for the quick review, @deadlycoconuts. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
appIconprop was removed from the Header component in an old PR: https://github.com/gojek/mlp/pull/15/files. This PR removes its usage from the codebase.Additionally, the internal dependency
golang.org/x/sysmod now expects a minimum of Go1.17, without which the CI job fails: https://github.com/gojek/mlp/actions/runs/3318163507/jobs/5481800377Per the document:
We already have Go 1.19. Bumping the Go version in the MLP API module to 1.18, to be consistent with other components like Merlin and Turing.