Add method to allow PrometheusClient to register additional metrics#73
Merged
deadlycoconuts merged 3 commits intoJan 4, 2023
Merged
Conversation
deadlycoconuts
force-pushed
the
expose_prometheus_client_maps
branch
from
d27d7a9 to
9a452b9
Compare
deadlycoconuts
changed the title
krithika369
reviewed
Dec 16, 2022
deadlycoconuts
commented
Jan 2, 2023
Collaborator
Author
|
Thanks a lot for the quick review! 🙏 Will be merging this! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces an additional method to the
PrometheusClientto allow the registration of additional metrics after the prior creation of aPrometheusClientobject (the existingInitPrometheusMetricsCollectorfunction creates a newPrometheusClientobject and registers metrics immediately).This change is needed as part of a series of other changes to the allow the XP's treatment service plugin to register additional metrics on the Turing Router's
PrometheusClient(see caraml-dev/turing#302 and caraml-dev/xp#54 for more information).