remove conf from image and add logwriter requirements#15
Merged
leonlnj merged 3 commits intocaraml-dev:mainfrom Jan 31, 2023
Merged
remove conf from image and add logwriter requirements#15leonlnj merged 3 commits intocaraml-dev:mainfrom
leonlnj merged 3 commits intocaraml-dev:mainfrom
Conversation
Member
|
What's the docker image size after including
How will it be achieved? |
Contributor
Author
|
its 18mb bigger (405 to 423mb) Im still WIP for a couple of stuff for caraml helm chart in this draft pr. Sample of how it looks like in the values.yaml The fluentd is isolated as a standalone, observation service will use it as a subchart and likewise logwriter will can supply it own values.yaml. The idea is to supply the fluentd.conf in helms values.yaml, then the fluentd chart will create a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is targeted the fluentd image to make it more generic for all use-cases within Timber.
Currently it is used by
The following changes are made
bigqueryandupi-proto-parserto fluentd imagejsonfield marshallingFluent config will be supplied during helm install, upi parser will be available as well due to the imports.