Skip to content

Conversation

@terryyylim
Copy link
Contributor

What this PR does / why we need it:
This PR improves test coverage by adding checks that have not been implemented for Segmenter workflows:

  • Constraint and single-valued checks
  • Missing dependent segmenters check

Which issue(s) this PR fixes:

NONE

@terryyylim terryyylim requested a review from leonlnj June 3, 2022 04:22
@terryyylim terryyylim self-assigned this Jun 3, 2022
@terryyylim
Copy link
Contributor Author

cc: @krithika369

Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@terryyylim terryyylim merged commit ba35ea7 into main Jun 3, 2022
@terryyylim terryyylim deleted the improve-segmenters-unit-tests branch June 14, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants