Fix UI runtime config #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonlnj
reviewed
Jun 14, 2022
|
|
||
| Sentry.init({ dsn, environment }); | ||
| Sentry.setTag("app", "xp-ui"); | ||
| Sentry.setTags(tags); |
Contributor
There was a problem hiding this comment.
changing setTag to setTags is intentionally i suppose?
Contributor
Author
There was a problem hiding this comment.
Yes intentional, since we can now set multiple tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A bug was introduced in a previous PR, where runtime configs were not able to load for 2 exported components for the parent app via the Micro-Frontend (MFE) architecture. This was due to missing Context Providers which have been added now to fix it.
In addition,
sentrytags have been added as a new attribute to be supported via runtime configs.Which issue(s) this PR fixes:
NONE