Skip to content

First version#1

Merged
JPTIZ merged 1 commit intocaravelahc:masterfrom
patrickelectric:something
Nov 17, 2020
Merged

First version#1
JPTIZ merged 1 commit intocaravelahc:masterfrom
patrickelectric:something

Conversation

@patrickelectric
Copy link
Copy Markdown
Contributor

@patrickelectric patrickelectric commented Nov 6, 2020

  • Add actions
  • Small project template
  • Add tests with isort, black, mypy and pylint

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@JPTIZ JPTIZ requested review from cauebs and tarcisioe November 6, 2020 20:24
@JPTIZ JPTIZ self-assigned this Nov 6, 2020
@JPTIZ JPTIZ added infra:ci Related to Continuous Integration infra:tests Related to Unit Tests. labels Nov 6, 2020
@tarcisioe
Copy link
Copy Markdown
Member

LGTM. I will approve as is, but what do you guys think of making this a cookiecutter template? Then the user doesn't need to edit things manually, instead being prompted by cookiecutter (for things such as project, author, e-mail...).

@JPTIZ
Copy link
Copy Markdown
Member

JPTIZ commented Nov 13, 2020

LGTM. I will approve as is, but what do you guys think of making this a cookiecutter template? Then the user doesn't need to edit things manually, instead being prompted by cookiecutter (for things such as project, author, e-mail...).

Just looked at it, makes a lot of sense to do it. The initial idea of this repo was to use as a template-repository (in Github terms), so we could easily generate projects from it (inheriting labels, etc.), but since we have already organization default labels, having this as a cookiecutter makes more sense.

@JPTIZ JPTIZ merged commit 47d3883 into caravelahc:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra:ci Related to Continuous Integration infra:tests Related to Unit Tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants