fix(context-menu): avoid clipping nested menu on narrow screens #2227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1847
This fixes submenu positioning on narrow viewports by improving the horizontal constraint logic in
ContextMenuOption.svelte.Currently, the submenu overflows the viewport on small screens because it only checks if there's space on the right side using an incorrect reference point (
menuOffsetX). The fix now uses the actual submenu width to check both right and left viewport boundaries, falling back to the viewport edge when the submenu would overflow on both sides.This fix is consistent with the React implementation.
Before
After