Skip to content

Commit 1a6eef8

Browse files
emyarodabbeyhrt
authored andcommitted
fix(FileUploader): move role attribute to valid element (#4209)
1 parent 652c0eb commit 1a6eef8

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

packages/react/src/components/FileUploader/FileUploader.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,8 @@ export class FileUploaderButton extends Component {
175175
}
176176
}}
177177
htmlFor={this.uid}
178-
role={role}
179178
{...other}>
180-
{this.state.labelText}
179+
<span role={role}>{this.state.labelText}</span>
181180
</label>
182181
<input
183182
className={`${prefix}--visually-hidden`}

packages/react/src/components/FileUploader/FileUploaderDropContainer.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,14 @@ export default function FileUploaderDropContainer(props) {
9898
<label
9999
className={labelClasses}
100100
htmlFor={id || uid.current}
101-
role={role || 'button'}
102101
tabIndex={tabIndex || 0}
103102
onKeyDown={evt => {
104103
if (matches(evt, [keys.Enter, keys.Space])) {
105104
inputRef.current.click();
106105
}
107106
}}
108107
{...other}>
109-
<div className={dropareaClasses}>
108+
<div className={dropareaClasses} role={role || 'button'}>
110109
{labelText}
111110
<input
112111
type="file"

0 commit comments

Comments
 (0)