Skip to content

Commit 4a3955e

Browse files
authored
fix(skeleton): updates skeleton state performance (#7965)
* fix(skeleton): updates skeleton state performance * chore(tests): update snapshots
1 parent d944ac5 commit 4a3955e

File tree

4 files changed

+40
-66
lines changed

4 files changed

+40
-66
lines changed

config/browserslist-config-carbon/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77

88
'use strict';
99

10-
module.exports = ['last 1 versions', 'ie >= 11', 'Firefox ESR'];
10+
module.exports = ['last 1 version', 'ie >= 11', 'Firefox ESR'];

packages/components/gulpfile.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -417,14 +417,7 @@ gulp.task('sass:dev', () => {
417417
})
418418
).on('error', sass.logError)
419419
)
420-
.pipe(
421-
postcss([
422-
customProperties(),
423-
autoprefixer({
424-
browsers: ['> 1%', 'last 2 versions'],
425-
}),
426-
])
427-
)
420+
.pipe(postcss([customProperties(), autoprefixer()]))
428421
.pipe(sourcemaps.write('.'))
429422
.pipe(gulp.dest('demo'))
430423
.pipe(browserSync.stream({ match: '**/*.css' }));

packages/components/src/globals/grid/__tests__/__snapshots__/grid-test.js.snap

Lines changed: 18 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -51,43 +51,34 @@ em {
5151
5252
@keyframes skeleton {
5353
0% {
54-
right: auto;
55-
left: 0;
56-
width: 0%;
54+
transform: scaleX(0);
55+
transform-origin: left;
5756
opacity: 0.3; }
5857
20% {
59-
right: auto;
60-
left: 0;
61-
width: 100%;
58+
transform: scaleX(1);
59+
transform-origin: left;
6260
opacity: 1; }
6361
28% {
64-
right: 0;
65-
left: auto;
66-
width: 100%; }
62+
transform: scaleX(1);
63+
transform-origin: right; }
6764
51% {
68-
right: 0;
69-
left: auto;
70-
width: 0%; }
65+
transform: scaleX(0);
66+
transform-origin: right; }
7167
58% {
72-
right: 0;
73-
left: auto;
74-
width: 0%; }
68+
transform: scaleX(0);
69+
transform-origin: right; }
7570
82% {
76-
right: 0;
77-
left: auto;
78-
width: 100%; }
71+
transform: scaleX(1);
72+
transform-origin: right; }
7973
83% {
80-
right: auto;
81-
left: 0;
82-
width: 100%; }
74+
transform: scaleX(1);
75+
transform-origin: left; }
8376
96% {
84-
right: auto;
85-
left: 0;
86-
width: 0%; }
77+
transform: scaleX(0);
78+
transform-origin: left; }
8779
100% {
88-
right: auto;
89-
left: 0;
90-
width: 0%;
80+
transform: scaleX(0);
81+
transform-origin: left;
9182
opacity: 0.3; } }
9283
9384
.bx--grid {

packages/components/src/globals/scss/_helper-mixins.scss

Lines changed: 20 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -185,13 +185,12 @@
185185

186186
&::before {
187187
position: absolute;
188-
top: 0;
189-
left: 0;
190-
width: 0%;
188+
width: 100%;
191189
height: 100%;
192190
background: $skeleton-02;
193191
animation: 3000ms ease-in-out skeleton infinite;
194192
content: '';
193+
will-change: transform-origin, transform, opacity;
195194

196195
@media (prefers-reduced-motion: reduce) {
197196
animation: none;
@@ -202,51 +201,42 @@
202201
@include exports('skeleton') {
203202
@keyframes skeleton {
204203
0% {
205-
right: auto;
206-
left: 0;
207-
width: 0%;
204+
transform: scaleX(0);
205+
transform-origin: left;
208206
opacity: 0.3;
209207
}
210208
20% {
211-
right: auto;
212-
left: 0;
213-
width: 100%;
209+
transform: scaleX(1);
210+
transform-origin: left;
214211
opacity: 1;
215212
}
216213
28% {
217-
right: 0;
218-
left: auto;
219-
width: 100%;
214+
transform: scaleX(1);
215+
transform-origin: right;
220216
}
221217
51% {
222-
right: 0;
223-
left: auto;
224-
width: 0%;
218+
transform: scaleX(0);
219+
transform-origin: right;
225220
}
226221
58% {
227-
right: 0;
228-
left: auto;
229-
width: 0%;
222+
transform: scaleX(0);
223+
transform-origin: right;
230224
}
231225
82% {
232-
right: 0;
233-
left: auto;
234-
width: 100%;
226+
transform: scaleX(1);
227+
transform-origin: right;
235228
}
236229
83% {
237-
right: auto;
238-
left: 0;
239-
width: 100%;
230+
transform: scaleX(1);
231+
transform-origin: left;
240232
}
241233
96% {
242-
right: auto;
243-
left: 0;
244-
width: 0%;
234+
transform: scaleX(0);
235+
transform-origin: left;
245236
}
246237
100% {
247-
right: auto;
248-
left: 0;
249-
width: 0%;
238+
transform: scaleX(0);
239+
transform-origin: left;
250240
opacity: 0.3;
251241
}
252242
}

0 commit comments

Comments
 (0)