feat(eslint): add rule for curly braces (#7761)

* feat(eslint): add rule for curly braces

* chore(project): run eslint and prettier

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Author: joshblack

config/eslint-config-carbon/base.js

@@ -9,7 +9,11 @@
 
 module.exports = {
   parser: 'babel-eslint',
-  extends: ['eslint:recommended', require.resolve('./plugins/jsdoc')],
+  extends: [
+    'eslint:recommended',
+    require.resolve('./rules/best-practices'),
+    require.resolve('./plugins/jsdoc'),
+  ],
   rules: {
     // Handle cases where we are destructuring but may not be using the initial
     // variables

config/eslint-config-carbon/rules/best-practices.js

@@ -0,0 +1,15 @@
+/**
+ * Copyright IBM Corp. 2018, 2018
+ *
+ * This source code is licensed under the Apache-2.0 license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+'use strict';
+
+module.exports = {
+  rules: {
+    // @see https://eslint.org/docs/rules/curly
+    curly: 'error',
+  },
+};

packages/cli/src/commands/sassdoc/tools.js

@@ -122,7 +122,9 @@ function createAnchorLink(name, heading) {
 function createMarkdownItem(item) {
   let str = '';
 
-  if (!item.context) return '';
+  if (!item.context) {
+    return '';
+  }
 
   let status = item.access === 'public' ? '✅' : '❌';
 
@@ -160,9 +162,13 @@ $${item.context.name}: ${item.context.value};
 
     if (item.parameter) {
       item.parameter.forEach((param) => {
-        if (paramStr) paramStr += `, `;
+        if (paramStr) {
+          paramStr += `, `;
+        }
         paramStr += `$${param.name}`;
-        if (param.default) paramStr += `: ${param.default}`;
+        if (param.default) {
+          paramStr += `: ${param.default}`;
+        }
       });
     }
 

packages/components/gulpfile.js

@@ -241,7 +241,9 @@ const convertToESMGulpPlugin = () =>
           }),
         ],
         onwarn: (warning, handle) => {
-          if (warning.code !== 'EMPTY_BUNDLE') handle(warning);
+          if (warning.code !== 'EMPTY_BUNDLE') {
+            handle(warning);
+          }
         },
       })
         .then((bundle) => bundle.generate({ format: 'esm' }))

packages/components/tests/pure-modules-test.js

@@ -71,7 +71,9 @@ describe('ES modules', () => {
         terser.terser(),
       ],
       onwarn: (warning, handle) => {
-        if (warning.code !== 'EMPTY_BUNDLE') handle(warning);
+        if (warning.code !== 'EMPTY_BUNDLE') {
+          handle(warning);
+        }
       },
       treeshake: {
         annotations: false,
@@ -103,7 +105,9 @@ describe('ES modules', () => {
         terser.terser(),
       ],
       onwarn: (warning, handle) => {
-        if (warning.code !== 'EMPTY_BUNDLE') handle(warning);
+        if (warning.code !== 'EMPTY_BUNDLE') {
+          handle(warning);
+        }
       },
       treeshake: {
         annotations: false,

packages/icon-build-helpers/src/builders/plugins/virtual.js

@@ -22,13 +22,18 @@ module.exports = function virtual(modules) {
     name: 'virtual',
 
     resolveId(id, importer) {
-      if (id in modules) return PREFIX + id;
+      if (id in modules) {
+        return PREFIX + id;
+      }
 
       if (importer) {
-        if (importer.startsWith(PREFIX))
+        if (importer.startsWith(PREFIX)) {
           importer = importer.slice(PREFIX.length);
+        }
         const resolved = path.resolve(path.dirname(importer), id);
-        if (resolvedIds.has(resolved)) return PREFIX + resolved;
+        if (resolvedIds.has(resolved)) {
+          return PREFIX + resolved;
+        }
       }
     },
 

packages/react/src/components/DataTable/tools/filter.js

@@ -28,7 +28,9 @@ export const defaultFilterRows = ({
   rowIds.filter((rowId) =>
     headers.some(({ key }) => {
       const id = getCellId(rowId, key);
-      if (typeof cellsById[id].value === 'boolean') return false;
+      if (typeof cellsById[id].value === 'boolean') {
+        return false;
+      }
       return ('' + cellsById[id].value)
         .toLowerCase()
         .includes(inputValue.toLowerCase());

packages/react/src/components/DatePicker/DatePicker.js

@@ -55,7 +55,9 @@ const carbonFlatpickrMonthSelectPlugin = (config) => (fp) => {
       return;
     }
     fp.monthElements.forEach((elem) => {
-      if (!elem.parentNode) return;
+      if (!elem.parentNode) {
+        return;
+      }
       elem.parentNode.removeChild(elem);
     });
     fp.monthElements.splice(

packages/react/src/components/MultiSelect/FilterableMultiSelect.js

@@ -221,11 +221,15 @@ export default class FilterableMultiSelect extends React.Component {
         this.setState({
           highlightedIndex: changes.highlightedIndex,
         });
-        if (!this.state.isOpen) this.handleOnMenuChange(true);
+        if (!this.state.isOpen) {
+          this.handleOnMenuChange(true);
+        }
         break;
       case Downshift.stateChangeTypes.keyDownEscape:
       case Downshift.stateChangeTypes.mouseUp:
-        if (this.state.isOpen) this.handleOnMenuChange(false);
+        if (this.state.isOpen) {
+          this.handleOnMenuChange(false);
+        }
         break;
       // Opt-in to some cases where we should be toggling the menu based on
       // a given key press or mouse handler
@@ -240,8 +244,9 @@ export default class FilterableMultiSelect extends React.Component {
             nextIsOpen = true;
           }
         }
-        if (this.state.isOpen !== nextIsOpen)
+        if (this.state.isOpen !== nextIsOpen) {
           this.handleOnMenuChange(nextIsOpen);
+        }
         break;
       }
     }
@@ -263,8 +268,9 @@ export default class FilterableMultiSelect extends React.Component {
           inputValue: inputValue || '',
         };
       });
-      if (Boolean(inputValue) !== this.state.isOpen)
+      if (Boolean(inputValue) !== this.state.isOpen) {
         this.handleOnMenuChange(Boolean(inputValue));
+      }
     }
   };
 

packages/react/src/components/MultiSelect/MultiSelect-story.js

@@ -225,7 +225,9 @@ export const WithChangeOnClose = withReadme(readme, () => {
   const [hasFocus, setHasFocus] = useState(false);
   const [active, setActive] = useState(false);
   const [selItems, setSelItems] = useState([items[0]]);
-  if (!hasFocus && active && selItems.length == 0) setActive(false);
+  if (!hasFocus && active && selItems.length == 0) {
+    setActive(false);
+  }
 
   return (
     <div style={{ width: 300 }}>
@@ -234,7 +236,9 @@ export const WithChangeOnClose = withReadme(readme, () => {
         checked={active}
         onChange={(a) => {
           setActive(a);
-          if (a) setSelItems([items[0]]);
+          if (a) {
+            setSelItems([items[0]]);
+          }
         }}
         labelText="Active"
       />