Skip to content

Commit db99425

Browse files
authored
fix(Slider): fix slider position based on value min and range (#5982)
1 parent cbaa85d commit db99425

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

packages/react/src/components/Slider/Slider-test.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ describe('Slider', () => {
2525
<Slider
2626
id={id}
2727
className="extra-class"
28-
value={50}
29-
min={0}
30-
max={100}
28+
value={1}
29+
min={1}
30+
max={3}
3131
step={1}
3232
/>
3333
);
@@ -56,6 +56,10 @@ describe('Slider', () => {
5656
expect(wrapper.props().value).toEqual(55);
5757
});
5858

59+
it('should accurately position slider on mount', () => {
60+
expect(wrapper.state().left).toEqual(0);
61+
});
62+
5963
it('should specify light version as expected', () => {
6064
expect(wrapper.props().light).toEqual(false);
6165
wrapper.setProps({ light: true });

packages/react/src/components/Slider/Slider.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ export default class Slider extends PureComponent {
424424
if (value == null) {
425425
value = this.state.value;
426426
}
427-
leftPercent = value / (range - this.props.min);
427+
leftPercent = (value - this.props.min) / range;
428428
}
429429

430430
if (useRawValue) {

0 commit comments

Comments
 (0)