Skip to content

Commit f020e54

Browse files
feat(CodeSnippet): add feedbackTimeout prop, z-index fix (#8171)
* feat(CodeSnippet): add feedbackTimeout to single, multi variants * style(CodeSnippet): adjust z-index values of feedback tooltip * style(tooltip): set z-index in mixin * chore(snapshot): update snapshots * chore(demo): remove demo story Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
1 parent 8abe3ae commit f020e54

File tree

5 files changed

+15
-3
lines changed

5 files changed

+15
-3
lines changed

packages/components/src/components/copy-button/_copy-button.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@
107107
.#{$prefix}--copy-btn__feedback {
108108
@include tooltip--content('icon');
109109

110-
z-index: 3;
111110
display: none;
112111
box-sizing: content-box;
113112
margin: auto;

packages/components/src/globals/scss/_tooltip.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
@mixin tooltip--content($tooltip-type: 'icon') {
3232
@include box-shadow;
3333

34+
z-index: z('floating');
3435
width: max-content;
3536
min-width: rem(24px);
3637
max-width: rem(208px);

packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,9 @@ Map {
377377
"feedback": Object {
378378
"type": "string",
379379
},
380+
"feedbackTimeout": Object {
381+
"type": "number",
382+
},
380383
"hideCopyButton": Object {
381384
"type": "bool",
382385
},

packages/react/src/components/CodeSnippet/CodeSnippet-story.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ const props = () => ({
4141
),
4242
disabled: boolean('Disabled (disabled)', false),
4343
light: boolean('Light variant (light)', false),
44-
feedback: text('Feedback text', 'Copied to clipboard'),
44+
feedback: text('Feedback text (feedback)', 'Copied to clipboard'),
45+
feedbackTimeout: number('Feedback text timout (feedbackTimeout)', 2000),
4546
showMoreText: text('Text for "show more" button', 'Show more'),
4647
showLessText: text('Text for "show less" button', 'Show less'),
4748
hideCopyButton: boolean('Hide copy button (hideCopyButton)', false),

packages/react/src/components/CodeSnippet/CodeSnippet.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ function CodeSnippet({
3030
children,
3131
disabled,
3232
feedback,
33+
feedbackTimeout,
3334
onClick,
3435
ariaLabel,
3536
copyLabel, //TODO: Merge this prop to `ariaLabel` in `v11`
@@ -165,7 +166,8 @@ function CodeSnippet({
165166
aria-label={copyLabel || ariaLabel}
166167
aria-describedby={uid}
167168
className={codeSnippetClasses}
168-
feedback={feedback}>
169+
feedback={feedback}
170+
feedbackTimeout={feedbackTimeout}>
169171
<code id={uid}>{children}</code>
170172
</Copy>
171173
);
@@ -221,6 +223,7 @@ function CodeSnippet({
221223
disabled={disabled}
222224
onClick={handleCopyClick}
223225
feedback={feedback}
226+
feedbackTimeout={feedbackTimeout}
224227
iconDescription={copyButtonDescription}
225228
/>
226229
)}
@@ -284,6 +287,11 @@ CodeSnippet.propTypes = {
284287
*/
285288
feedback: PropTypes.string,
286289

290+
/**
291+
* Specify the time it takes for the feedback message to timeout
292+
*/
293+
feedbackTimeout: PropTypes.number,
294+
287295
/**
288296
* Specify whether or not a copy button should be used/rendered.
289297
*/

0 commit comments

Comments
 (0)