fix(ComboBox): prevent invalid option retention on Enter (#8476)

emyarod · kodiakhq[bot] · web-flow · commit fe9d56a2aed3 · 2021-04-30T16:06:38.000Z
Co-authored-by: kodiakhq[bot] &lt;49736102+kodiakhq[bot]@users.noreply.github.com&gt;
diff --git a/packages/react/src/components/ComboBox/ComboBox.js b/packages/react/src/components/ComboBox/ComboBox.js
@@ -267,7 +267,7 @@ const ComboBox = (props) => {
               event.stopPropagation();
             }
 
-            if (match(event, keys.Enter)) {
+            if (match(event, keys.Enter) && !inputValue) {
               toggleMenu();
             }
           },

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ const ComboBox = (props) => {`
`267`	`267`	`event.stopPropagation();`
`268`	`268`	`}`
`269`	`269`
`270`		`- if (match(event, keys.Enter)) {`
	`270`	`+ if (match(event, keys.Enter) && !inputValue) {`
`271`	`271`	`toggleMenu();`
`272`	`272`	`}`
`273`	`273`	`},`