Skip to content

Conversation

@MariaThomson
Copy link
Contributor

@MariaThomson MariaThomson commented Sep 12, 2025

Closes #19880 #20469

Fixed background colour in a zebra styled DataTable with Expansion . Now every even row will have a grey background instead of odd rows.

Changelog

New

  • N/A

Changed

Fixed row styling (background colour) In a zebra styled DataTable with Expansion

Removed

  • N/A

Testing / Reviewing

  • Used the storybook for carbon/react to check if zebra styles are getting applied correctly when useZebraStyles prop is true
Screenshot 2025-09-12 at 2 16 44 PM

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@MariaThomson MariaThomson requested a review from a team as a code owner September 12, 2025 08:54
@netlify
Copy link

netlify bot commented Sep 12, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 6f95f4e
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/68d52c10079f8d0008028e35
😎 Deploy Preview https://deploy-preview-20512--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 12, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6f95f4e
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/68d52c1009aedc00085cecae
😎 Deploy Preview https://deploy-preview-20512--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.93%. Comparing base (30b4f87) to head (6f95f4e).
⚠️ Report is 246 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20512      +/-   ##
==========================================
+ Coverage   91.39%   91.93%   +0.54%     
==========================================
  Files         485      484       -1     
  Lines       31370    32772    +1402     
  Branches     5430     5578     +148     
==========================================
+ Hits        28670    30130    +1460     
+ Misses       2547     2496      -51     
+ Partials      153      146       -7     
Flag Coverage Δ
main-packages 85.25% <ø> (+0.32%) ⬆️
web-components 97.25% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@netlify
Copy link

netlify bot commented Sep 12, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6f95f4e
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/68d52c10083cd80008cff28a
😎 Deploy Preview https://deploy-preview-20512--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@maradwan26 maradwan26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tay1orjones tay1orjones added this pull request to the merge queue Sep 30, 2025
Merged via the queue into carbon-design-system:main with commit 5c1a375 Sep 30, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DataTable Expansion Zebra Styling

4 participants