Make various effiency changes to filtering resource group logic.#20
Merged
CCPCookies merged 5 commits intocarbonengine:mainfrom Mar 27, 2026
Merged
Make various effiency changes to filtering resource group logic.#20CCPCookies merged 5 commits intocarbonengine:mainfrom
CCPCookies merged 5 commits intocarbonengine:mainfrom
Conversation
Collaborator
CCPCookies
commented
Mar 25, 2026
CCPCookies
commented
- Reduce hot codepaths in filtering logic.
- Introduce parallelism for the process.
- Add generic threadpool in resource tools.
Reduce hot codepaths in filtering logic. Introduce parallelism for the process. Add generic threadpool in resource tools.
Collaborator
ccp-chargeback
left a comment
ccp-chargeback
left a comment
There was a problem hiding this comment.
I left a few questions/comments
ccp-chargeback
previously approved these changes
Mar 26, 2026
Argument evaluation difference on from Windows to macOS was causing an error. Windows appears to evalulate the second parameter first which still holds the data and then the capture after which was using move. When evalulated the other way round the second parameter is now empty. Fixed by removing the move so the object is valid for both instances.
ccp-chargeback
approved these changes
Mar 27, 2026
Collaborator
ccp-chargeback
left a comment
ccp-chargeback
left a comment
There was a problem hiding this comment.
Approve incoming changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.