-
Notifications
You must be signed in to change notification settings - Fork 4
Add cardano-tracer and tracer-sidecar images
#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
71be9af to
66b9e8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think you should use a separate Docker image for building the tracer image. It takes more than an hour to build everything already and if we start to build every image with cardano-node (we may want relays, dbsync etc in the future) it will take for ever.
You need to add the image in the json to the anti build target for the tracer image to be used by antithesis.
6250f63 to
a46dd60
Compare
|
Is this PR still problematic? (apart from the fact it conflicst with base branch) |
Co-authored-by: Arnaud Bailly <arnaud@pankzsoft.com>
85cca94 to
65679e5
Compare
As discussed, it should only need to be built once, and not need to be rebuilt even if we change the revision of the cardano-node image etc.
Done.
I don't think so — I ran |
|
|
So I guess this is good to go? |
Add `tracer-sidecar` and "Sometimes forks" assertion
cardano-tracer and tracer-sidecar images
Yes, it should be good to go, just waiting on approval (or at least absence of objections) from @karknu |
|
It does not impact @karknu 's tests so I guess we can move on. merging. |
This PR adds a
cardano-tracerimage and container to theexamplestack, along with some documentation on how to use it. It does not (yet) leverage the existence of the tracer to write test templates and express properties.fix #4
includes #11