Skip to content

Conversation

@Anviking
Copy link
Member

@Anviking Anviking commented Apr 10, 2025

This PR adds a cardano-tracer image and container to the example stack, along with some documentation on how to use it. It does not (yet) leverage the existence of the tracer to write test templates and express properties.

fix #4

includes #11

@abailly abailly force-pushed the anviking/cardano-tracer branch 2 times, most recently from 71be9af to 66b9e8f Compare April 13, 2025 07:59
@abailly abailly marked this pull request as ready for review April 13, 2025 08:05
@abailly abailly requested a review from karknu April 13, 2025 08:06
@abailly abailly changed the title wip: forward node logs with cardano-tracer Forward node logs with cardano-tracer Apr 13, 2025
Copy link
Collaborator

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think you should use a separate Docker image for building the tracer image. It takes more than an hour to build everything already and if we start to build every image with cardano-node (we may want relays, dbsync etc in the future) it will take for ever.

You need to add the image in the json to the anti build target for the tracer image to be used by antithesis.

@Anviking Anviking force-pushed the anviking/cardano-tracer branch from 6250f63 to a46dd60 Compare April 16, 2025 13:52
@abailly
Copy link
Collaborator

abailly commented Apr 28, 2025

Is this PR still problematic? (apart from the fact it conflicst with base branch)

@Anviking Anviking force-pushed the anviking/cardano-tracer branch from 85cca94 to 65679e5 Compare May 6, 2025 17:14
@Anviking
Copy link
Member Author

Anviking commented May 7, 2025

I don’t think you should use a separate Docker image for building the tracer image. It takes more than an hour to build everything already and if we start to build every image with cardano-node (we may want relays, dbsync etc in the future) it will take for ever.

As discussed, it should only need to be built once, and not need to be rebuilt even if we change the revision of the cardano-node image etc.

You need to add the image in the json to the anti build target for the tracer image to be used by antithesis.

Done.

Is this PR still problematic? (apart from the fact it conflicst with base branch)

I don't think so — I ran example_10.2.1 with #11 included and it still works also.

@Anviking Anviking requested a review from karknu May 7, 2025 09:55
@Anviking
Copy link
Member Author

Anviking commented May 7, 2025

You need to add the image in the json to the anti build target for the tracer image to be used by antithesis.

Done.

Ok, actually not included in this PR atm 👀 now merged though

@abailly
Copy link
Collaborator

abailly commented May 7, 2025

So I guess this is good to go?

@Anviking Anviking changed the title Forward node logs with cardano-tracer Add cardano-tracer and tracer-sidecar images May 7, 2025
@Anviking
Copy link
Member Author

Anviking commented May 7, 2025

So I guess this is good to go?

Yes, it should be good to go, just waiting on approval (or at least absence of objections) from @karknu

@abailly
Copy link
Collaborator

abailly commented May 7, 2025

It does not impact @karknu 's tests so I guess we can move on. merging.

@abailly abailly merged commit 602952f into main May 7, 2025
@abailly abailly deleted the anviking/cardano-tracer branch May 23, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate cardano-tracer into docker-compose stack for running tests

4 participants