Fix/cc vote count #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mesudip
requested changes
Mar 25, 2025
src/repository/proposal.ts
Outdated
| LEFT JOIN RatifiedCommitteeGovAction rc | ||
| ON rc.id = c.gov_action_proposal_id | ||
| WHERE c.gov_action_proposal_id IS NULL | ||
| GROUP BY c.quorum_numerator, c.quorum_denominator |
Contributor
There was a problem hiding this comment.
The group by clause makes no sense
Contributor
Author
There was a problem hiding this comment.
Truly sorry for forgetting to remove this. It was in the gov-state/committee endpoint query where grouping by numerator and denominator was required and i copied it from there. Thank you for the profound insight. It indeed does not make sense. I have removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.