Skip to content

Use .sum instead of .inject for summing #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cardmagic merged 1 commit into from
Dec 27, 2025
Merged

Use .sum instead of .inject for summing #82

cardmagic merged 1 commit into from
Dec 27, 2025

Conversation

@cardmagic
Copy link
Owner

@cardmagic cardmagic commented Dec 27, 2025

Summary

Replace legacy inject patterns with modern Ruby .sum method.

Changes

# Before
proximity_array_for_content(x).inject(0.0) { |i, j| i + j[1] }
votes.values.inject(0.0) { |sum, v| sum + v }

# After
proximity_array_for_content(x).sum { |pair| pair[1] }
votes.values.sum

Benefits

  • Cleaner, more idiomatic Ruby
  • Native implementation (slightly better performance)

Fixes #71

@cardmagic
refactor: use .sum instead of .inject for summing
100679e 
Replace legacy inject patterns with modern Ruby .sum method:
- LSI#highest_relative_content
- LSI#classify_with_confidence

Fixes #71
@cardmagic cardmagic merged commit 870fef3 into master Dec 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modernize Ruby idioms: use .sum instead of inject

2 participants

@cardmagic