ci: Add path-based filtering to main workflow#2677
Merged
Conversation
Deployment requires ai-bot tests to pass.
backspace
changed the title
backspace
changed the title
backspace
commented
May 29, 2025
| - 'packages/realm-server/**' | ||
| - 'packages/runtime-common/**' | ||
| - 'pnpm-lock.yaml' | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Since so many of the jobs now depend on this, I moved it to the top.
backspace
commented
May 29, 2025
| @@ -1,4 +1,4 @@ | |||
| name: CI Preview Host | |||
Contributor
Author
There was a problem hiding this comment.
I renamed the file and workflow for clarity.
lukemelia
approved these changes
May 29, 2025
jurgenwerk
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of this is to ensure that changes in
packages/ai-botdon’t cause the tests and Percy jobs forpackages/hostto run, which are sadly flaky and slow. But I added path-based filtering to many of the jobs in the main workflow so PRs that focus on a particular package don’t produce unrelated Actions jobs.I originally tried moving the
ai-botjob into its own workflow but thedeployjob checks its passing status, which wouldn’t work across workflows.These are the jobs that ran and didn’t when I made a fake
ai-botchange (and removed.github/workflows/ci.ymlfrom the shared path filter):