Merged
Conversation
fdca8c6 to
2c2a3a6
Compare
backspace
reviewed
Sep 10, 2025
| * - "tags[0]" → ["tags", "[0]"] | ||
| * - "authors[0].name" → ["authors", "[0]", "name"] | ||
| * - "tags[]" → ["tags", "[]"] (append operation) | ||
| * - "tags[-1]" → ["tags", "[-1]"] (append operation) |
Contributor
There was a problem hiding this comment.
I don’t understand how these mean “append”, can you share examples?
Contributor
Author
There was a problem hiding this comment.
It is conventional from rails and form libraries. I showed GPT-5 each of the following code snippets and asked what it meant and it understood both as appending "ok" to the tags array:
updateFields(instance, {
"tags[]": "ok",
});
updateFields(instance, {
"tags[-1]": "ok",
});
Contributor
There was a problem hiding this comment.
👍🏻 thanks, I didn’t understand what was being appended, but I see now
The `PatchFieldsCommand` is a new command that allows updating specific fields of a card instance rather than patching the entire card. This provides more granular control and better performance for targeted updates.
2c2a3a6 to
8f0a976
Compare
lukemelia
added a commit
to cardstack/boxel-skills
that referenced
this pull request
Sep 10, 2025
…d-that-allows-updating
The `PatchFieldsCommand` is a new command that allows updating specific fields of a card instance rather than patching the entire card. This provides more granular control and better performance for targeted updates.
backspace
approved these changes
Sep 11, 2025
lukemelia
added a commit
to cardstack/boxel-skills
that referenced
this pull request
Sep 11, 2025
…h-card-command-that-allows-updating-skills Skills update for cardstack/boxel#3219 (Patch Fields command)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PatchFieldsCommandis a new command that allows updating specific fields of a card instance rather than patching the entire card. This provides more granular control and better performance for targeted updates.