Skip to content

Conversation

@lucaslyl
Copy link
Contributor

@lucaslyl lucaslyl commented Jan 16, 2026

linear: https://linear.app/cardstack/issue/CS-10066/point-the-code-ref-of-field-spec-to-field

  • Update all field-spec instance JSON files to point ref.name and ref.module to the actual field classes in fields/ directory instead of field-spec files.

Demo:
image

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Host Test Results

    1 files  ±    0      1 suites  ±0   2h 59m 30s ⏱️ + 1h 20m 20s
1 676 tests  -   211  1 657 ✅  -   215  15 💤 ± 0  2 ❌ +2  2 🔥 +2 
3 377 runs  +1 475  3 341 ✅ +1 454  30 💤 +15  4 ❌ +4  2 🔥 +2 

For more details on these failures and errors, see this check.

Results for commit 92f229d. ± Comparison against base commit 1e989a1.

This pull request removes 213 and adds 2 tests. Note that renamed tests count towards both.
Chrome ‑ Integration | Store: added instance that was previously not saved will begin to auto save after being added
Chrome ‑ Integration | Store: an instance can be restored after a loader reset
Chrome ‑ Integration | Store: an instance can debounce auto saves
Chrome ‑ Integration | Store: an instance can live update thru an error state
Chrome ‑ Integration | Store: an instance live updates from indexing events for a code update
Chrome ‑ Integration | Store: an instance live updates from indexing events for an instance update
Chrome ‑ Integration | Store: an instance that started out with a local ID can be restored after a loader reset
Chrome ‑ Integration | Store: an instance will NOT auto save when its data changes, if the user does not have write permissions
Chrome ‑ Integration | Store: an instance will auto save when its data changes
Chrome ‑ Integration | Store: an unsaved instance live updates when realm event matching local ID is received
…
Chrome ‑ Global error: Uncaught TypeError: Failed to fetch at http://localhost:7357/assets/chunk.94b2fb35378d2c95609c.js, line 150984  While executing test: Integration | card-copy: copy button does not appear when right and left stacks are both single cards items 
Chrome ‑ Global error: Uncaught TypeError: Failed to fetch at http://localhost:7357/assets/chunk.94b2fb35378d2c95609c.js, line 150984  While executing test: Integration | card-copy: copy button does not appear when right and left stacks are the same index item and there is a selection on one side 

♻️ This comment has been updated with latest results.

@lucaslyl lucaslyl force-pushed the CS-10066-point-the-code-ref-of-field-spec-to-field branch from 56de20c to 4de5abf Compare January 16, 2026 07:44
"readMe": null,
"ref": {
"module": "http://localhost:4201/catalog/fields/image/components/image-presentation",
"module": "../fields/image/components/image-presentation",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt delete these component spec because it used in one of the CardListing

@lucaslyl lucaslyl self-assigned this Jan 16, 2026
@lucaslyl lucaslyl requested a review from a team January 16, 2026 08:07
@lucaslyl lucaslyl marked this pull request as ready for review January 16, 2026 08:07
/>
</template>
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why having two exports? I think there are consequences to this when for example you auto create-specs? If you dont want the default name I wud say just remove the default export imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the advice — I agree this can be confusing, as the current catalog-realm fields have evolved with different export patterns over time. Based on Burcu’s earlier guidance to favor default exports for consistency and flexible imports, I did a cleanup in catalog-realm so the related fields now follow the same export default pattern, giving us a single consistent format to follow going forward.

@lucaslyl lucaslyl requested a review from tintinthong January 18, 2026 15:47
@github-actions
Copy link

Preview deployments

@lucaslyl lucaslyl merged commit 10d957c into main Jan 19, 2026
162 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants