Update custom domain publishing approach #3917
Conversation
Preview deployments |
ugh what is happening
backspace
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be20c6cc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13975e58ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let overriddenURL = new URL(publishedRealmURL); | ||
| overriddenURL.host = overrideDomain; |
There was a problem hiding this comment.
The override value is fed directly into URL.host, but overrides can come from env JSON and the server-side parser explicitly accepts full URLs (e.g. https://whitepaper.boxel.ai). If the override includes a scheme, overriddenURL.host = overrideDomain produces a malformed URL like https://https/, which then shows a broken URL in the modal and causes publish requests to fail for those overrides. Consider parsing/normalizing the override string to hostname/port (or stripping scheme) before assigning it to host.
Useful? React with 👍 / 👎.
More requirements have emerged so I’m adapting the implementation of custom domain publishing, which is a workaround until we have full support for dynamic creation of CNAMES and the like.
PUBLISHED_REALM_DOMAIN_OVERRIDESis an environment variable that lets us add to the hardcoded mapping without requiring a full deployment.PUBLISHED_REALM_DOMAIN_OVERRIDESthrough from the realm server’sindex.html-serving function.