server: Remove SSR for is_deleted IS TRUE
#3924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backspace
commented
Jan 29, 2026
| timeoutMessage: | ||
| 'Timed out waiting for deleted index entries to be tombstoned', | ||
| }, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
I don’t love polling the database to make sure the deletion has been recorded but is there a better way?
lukemelia
approved these changes
Jan 29, 2026
Contributor
lukemelia
left a comment
lukemelia
left a comment
There was a problem hiding this comment.
It's not new in this PR, but host mode serving should not be pulling from boxel_index_working, only boxel_index
lukemelia
pushed a commit
that referenced
this pull request
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another consequence of using the index as a source of truth vs the filesystem.
You can see the test fail here before I added the fix.