Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e639819fab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +0,0 @@ | |||
| use-node-version=24.13.1 | |||
There was a problem hiding this comment.
use-node-version for plain pnpm invocations
Removing this file regresses any workflow that runs bare pnpm ... outside a mise-activated shell. I checked locally with pnpm 10.18.3: pnpm exec node -v switches from v24.13.1 to the shell’s v20.19.6 as soon as .npmrc is deleted. That still affects documented setup/start flows that say mise install and then plain pnpm install (README.md:10-11, QUICKSTART.md:19-20) plus scripts/start-host.sh:20; mise install only downloads the toolchain, it does not make those later pnpm commands run under Node 24 unless the user has separately activated mise.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
hmm I’ll just close this then, there are still situations where we don’t use mise to run everything
1 participant
This is copied from #3969, something I should have included in #4158.