Do not show loading screen on hosted site#4257
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c41fe5b3ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Preview deployments |
Contributor
burieberry
force-pushed
the
cs-10399-host-mode-hide-loading-screen
branch
from
0a02377 to
4c15d17
Compare
backspace
reviewed
Mar 27, 2026
| (await page.locator('[data-test-host-loading]').count()) === 0, | ||
| ); | ||
|
|
||
| await page.locator('[data-test-host-mode-card-loaded').waitFor(); |
Contributor
There was a problem hiding this comment.
Adding the missing ] here might make it pass?
Contributor
Author
There was a problem hiding this comment.
Ah good catch. I had trouble getting playwright tests to run locally
Contributor
There was a problem hiding this comment.
eep what was happening? I have trouble with many things but let me know if the mise changes seem related?
backspace
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading...screen on hosted card