-
Notifications
You must be signed in to change notification settings - Fork 12
Support preselected examples in create listing modal #4283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tintinthong
merged 9 commits into
main
from
CS-10547/implement-preselected-logic-on-modal-card-chooser
Apr 1, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a24a48d
Support preselected examples in create listing modal
lucaslyl 888f041
Fix removeSelectedExample to normalize URLs before filtering
lucaslyl 6312b01
fix lint
lucaslyl c77387e
Replace test-only selector in runtime CSS
lucaslyl 72286c3
Merge branch 'main' into CS-10547/implement-preselected-logic-on-moda…
lucaslyl e9bf82d
fix test
lucaslyl aeeddfe
fix codex feedback & fix lint
lucaslyl 38526c3
update example field ui
lucaslyl b873a46
fix host test
lucaslyl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selectedRealmsis initialized with a newly constructedPickerOptionwhenpreselectConsumingRealmis enabled. The BoxelPicker(used byRealmPicker) determines selection via object identity (includes(selected, option)), so this preselected option will not match the options instances created insideRealmPicker. This can cause the consuming realm to not appear selected in the dropdown and can lead to toggle/deselect issues (duplicates) when interacting with the picker. Consider preselecting by realm URL and mapping to the actual option objects used by the picker (or providing an id-based matcher) soselectedreferences come from the current@optionsarray.