ci(boxel-cli): use pnpm publish in manual release workflow#4778
Merged
Conversation
The workflow calls `npm publish` directly, bypassing the `publish:npm` script in package.json. As a result the previous fix to that script had no effect — the just-released 0.1.1 tarball still contains raw `catalog:` specifiers in dependencies and is unusable via `npm install`. Switch the workflow's publish step to `pnpm publish` so the catalog protocol is rewritten to concrete versions before the tarball is uploaded. `--no-git-checks` is needed because the workflow has already committed the version bump and tag. The next run will bump to 0.1.2 and publish a clean tarball. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
tintinthong
approved these changes
May 12, 2026
lucaslyl
approved these changes
May 12, 2026
FadhlanR
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/boxel-cli/package.json'spublish:npmscript to usepnpm publish, but the actual release workflow at.github/workflows/manual-boxel-cli-publish.ymlinvokesnpm publishdirectly — it never calls thepublish:npmscript. So the fix didn't take effect, and the freshly released0.1.1still has rawcatalog:specifiers independencies(seenpm view @cardstack/boxel-cli@0.1.1 dependencies).pnpm publish, which rewrites everycatalog:specifier to its concrete version frompnpm-workspace.yaml's catalog block before uploading the tarball.--no-git-checksis needed because the workflow has already committed the version bump and tag at the point publish runs; pnpm would otherwise refuse over the local commit.Test plan
patch+staging. Expected: bump to0.1.2, beta tag.npm view @cardstack/boxel-cli@beta dependencies— should show concrete versions (e.g."ignore": "^5.x.x"), nocatalog:strings.patch+productionto publish@latest.Note:
0.1.1on npm stays as a known-bad release on thebetatag. Unpublishing is intentionally avoided (npm restricts removal after 72h and it would invalidate the version number for anyone who already resolved it).🤖 Generated with Claude Code