Skip to content

Pin down singular linksTo userland JS-access contract #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
habdelra merged 6 commits into from
May 30, 2026
Merged

Pin down singular linksTo userland JS-access contract #5024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b20d4d
Pin down singular linksTo userland JS-access contract
habdelra May 28, 2026
af39876
Fix lint in linksTo singular JS-access contract test
habdelra May 28, 2026
b7f3b0f
Collapse unset singular linksTo to undefined in the userland getter
habdelra May 28, 2026
0988760
Soften the not-set bucket assertion to forbid sentinel objects only
habdelra May 28, 2026
ee7632b
Merge origin/main into cs-11219 (pick up host live-test bootstrap fix)
habdelra May 28, 2026
0068ffd
Migrate serialization tests off === null for empty linksTo
habdelra May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/base/card-api.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ export {
getFieldDescription,
getFields,
getRelationship,
isNonPresentLink,
peekAtField,
isCard,
isField,
Expand Down Expand Up @@ -1245,7 +1246,11 @@ class LinksTo<CardT extends LinkableDefConstructor> implements Field<CardT> {
}
let value = getter(instance, this);
trackRuntimeRelationshipDependency(value, this.card);
return value;
// An unset linksTo falls through to LinksTo.emptyValue() which returns
// `null`; the userland contract is that every non-present state — including
// not-set — surfaces as `undefined`, so all four non-present discriminants
// collapse to one nullish shape.
return value ?? undefined;
}

queryableValue(instance: any, stack: CardDef[]): any {
Expand Down
8 changes: 4 additions & 4 deletions packages/host/app/lib/gc-card-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,10 +1032,10 @@ function findInstances(
if (isFileDefInstance(obj)) {
return [obj];
}
if (
(obj as { type?: unknown; reference?: unknown }).type === 'not-loaded' &&
typeof (obj as { reference?: unknown }).reference === 'string'
) {
// A sentinel in the bucket (not-loaded / link-error / link-not-found) is
// never an instance and never owns instance references — skip the recursion
// so its `errorDoc` and `reference` fields are not walked as a generic object.
if (api.isNonPresentLink(obj)) {
return [];
}
if (isBaseDefInstance(obj)) {
Expand Down
Loading
Loading