CS-11326: standardize sort + selection-menu triggers on CaretDown (flip on open)#5114
Conversation
lukemelia
changed the base branch from
cs-11325-card-chooser-selection-trigger-reconsider-adorn-pill-vs
to
main
Preview deploymentsHost Test Results 1 files 1 suites 1h 50m 25s ⏱️ Results for commit 157f837. Realm Server Test Results 1 files ± 0 1 suites ±0 13m 9s ⏱️ + 3m 6s Results for commit 157f837. ± Comparison against earlier commit 4461b18. |
…flip on open) CS-11326. The sort menu used a different arrow (filled DropdownArrowDown) than boxel-ui's form controls (select/multi-select/picker/dropdown all use the thin CaretDown chevron) and never flipped on open. Switch the sort and selection-menu triggers to CaretDown and flip the sort caret on open via the trigger's aria-expanded state (the selection-menu caret already flipped). Scoped to the toolbar triggers; the ~8 host-chrome DropdownArrowDown usages are left as-is. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lukemelia
force-pushed
the
cs-11326-standardize-dropdown-arrow
branch
from
4461b18 to
157f837
Compare
There was a problem hiding this comment.
Pull request overview
Standardizes the dropdown trigger affordance in boxel-ui toolbar controls by replacing the filled down-arrow icon with the thin CaretDown chevron and ensuring the sort trigger visually indicates open state by flipping the caret when the dropdown is expanded.
Changes:
SortDropdownnow usesCaretDownand flips the caret based onaria-expanded='true'.SelectionMenutrigger icon is switched fromDropdownArrowDowntoCaretDownto match other boxel-ui form controls.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/boxel-ui/addon/src/components/sort-dropdown/index.gts | Replaces the trigger icon with CaretDown and adds open-state caret flip styling via aria-expanded. |
| packages/boxel-ui/addon/src/components/selection-menu/index.gts | Replaces the trigger icon with CaretDown to align trigger visuals with other boxel-ui dropdown/select controls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CS-11326. The sort menu used the filled
DropdownArrowDownand never flipped on open; boxel-ui's form controls (select/multi-select/picker/dropdown) all use the thinCaretDownchevron and flip. Switch thesort-dropdownandselection-menutriggers toCaretDown, and flip the sort caret on open via itsaria-expandedstate.Scope decision: toolbar triggers only — the ~8 host-chrome
DropdownArrowDownusages are intentionally left alone.First of three PRs split out of #5105 (stacked): this one →
cs-11325; CS-11327 → this; CS-11328 → CS-11327. Verified live earlier in the combined branch.🤖 Generated with Claude Code