CS-11327: reserve a stable width for the selection-menu count#5115
Merged
Conversation
Contributor
Preview deploymentsHost Test Results 1 files 1 suites 1h 50m 0s ⏱️ Results for commit 1a28f7d. Realm Server Test Results 1 files ± 0 1 suites ±0 12m 15s ⏱️ + 2m 24s Results for commit 1a28f7d. ± Comparison against earlier commit 7f18293. |
CS-11327. Give the count a 2ch minimum width with tabular figures so the trigger doesn't shift when the count crosses 1↔2 digits (e.g. a Select All jumping 9→10). Height already matches the adjacent sort button via the shared --boxel-button-sm min-height. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lukemelia
force-pushed
the
cs-11326-standardize-dropdown-arrow
branch
from
4461b18 to
157f837
Compare
lukemelia
force-pushed
the
cs-11327-selection-trigger-sizing
branch
from
7f18293 to
1a28f7d
Compare
jurgenwerk
approved these changes
Jun 5, 2026
burieberry
approved these changes
Jun 5, 2026
lukemelia
changed the base branch from
cs-11326-standardize-dropdown-arrow
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CS-11327. Give the selection-menu count a 2ch minimum width with tabular figures so the trigger doesn't shift when the count crosses 1↔2 digits (e.g. a Select All jumping 9→10). Trigger height already matches the adjacent sort button via the shared
--boxel-button-smmin-height.Second of three PRs split out of #5105. Stacked on CS-11326 — review/merge that first; this PR's diff is just the count change.
🤖 Generated with Claude Code