Skip to content

Styling containsMany primitive field within card#650

Merged
FadhlanR merged 3 commits intomainfrom
cs-6022-styling-primive-field-containsMany-in-card
Sep 19, 2023
Merged

Styling containsMany primitive field within card#650
FadhlanR merged 3 commits intomainfrom
cs-6022-styling-primive-field-containsMany-in-card

Conversation

@FadhlanR
Copy link
Copy Markdown
Contributor

Ticket: CS-6022

Screen.Recording.2023-09-15.at.18.00.34.mov

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 15, 2023

Test Results

383 tests  ±0   376 ✔️ ±0   6m 0s ⏱️ +35s
    1 suites ±0       7 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 1bfa975. ± Comparison against base commit e03d88b.

♻️ This comment has been updated with latest results.

@habdelra
Copy link
Copy Markdown
Contributor

the padding looks uneven. in the ticket there is an even amount of padding for all side. but in your PR the padding for the left and right is about half as much as the padding for the top and bottom.

@FadhlanR
Copy link
Copy Markdown
Contributor Author

the padding looks uneven. in the ticket there is an even amount of padding for all side. but in your PR the padding for the left and right is about half as much as the padding for the top and bottom.

Updated.
Screenshot 2023-09-18 at 12 57 55

Copy link
Copy Markdown
Contributor

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Percy is showing some unintended changes

@FadhlanR FadhlanR requested a review from lukemelia September 18, 2023 15:56
@FadhlanR FadhlanR merged commit 56cadec into main Sep 19, 2023
@delete-merged-branch delete-merged-branch Bot deleted the cs-6022-styling-primive-field-containsMany-in-card branch September 19, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants