Improve error handling#162
Merged
carllerche merged 5 commits intocarllerche:masterfrom Nov 30, 2018
manifest:feature/errors
Merged
Improve error handling#162carllerche merged 5 commits intocarllerche:masterfrom manifest:feature/errors
carllerche merged 5 commits intocarllerche:masterfrom
manifest:feature/errors
Conversation
carllerche
requested changes
Nov 30, 2018
Owner
carllerche
left a comment
carllerche
left a comment
There was a problem hiding this comment.
Thanks for doing this. The strategy looks good. We need to maintain backwards compat for now though. Commented inline
| } | ||
|
|
||
| /// Returns `true` if `self` represents a 400 -- bad request error | ||
| pub fn is_bad_request(&self) -> bool { |
Owner
There was a problem hiding this comment.
These functions need to stay as they are part of the public API. They can be considered for removal in the next breaking release.
carllerche
approved these changes
Nov 30, 2018
Owner
carllerche
left a comment
carllerche
left a comment
There was a problem hiding this comment.
LGTM. Happy to merge whenever you are ready (I still see WIP in the title).
Owner
|
Woops, the WIP is gone, it was a relic of my email... |
Contributor
Author
|
Thanks! |
kornholi
pushed a commit
to kornholi/tower-web
that referenced
this pull request
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR for the issue.