Namespace OpenCV compile definition and make PUBLIC#295
Merged
ethanmusser merged 3 commits intoMay 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mattalvarado
approved these changes
May 15, 2026
Member
|
I think this is good and probably should be applied similarly to my feature in #285, binding to the target is better than exposing explicitly via the config. |
jmonticelli
approved these changes
May 15, 2026
ethanmusser
changed the title
PUBLICPUBLIC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the private
HAVE_OPENCVcompile definition with the publicMULTISENSE_HAVE_OPENCV. This new definition leaks to library consumers, so the#define HAVE_OPENCV 1line is no longer needed in consumer source files.This may be part of the issue seen in #294.