[health] Fix #1059: Add check flags for permissions#1069
Merged
iarata merged 2 commits intocarp-dk:masterfrom Nov 28, 2024
Merged
[health] Fix #1059: Add check flags for permissions#1069iarata merged 2 commits intocarp-dk:masterfrom
iarata merged 2 commits intocarp-dk:masterfrom
Conversation
iarata
changed the title
SlimShadyIAm
approved these changes
Nov 6, 2024
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until version 11.1.0 when there are multiple requests for permission on Android the app crashes carp-dk/carp-health-flutter#98. This can be reproduced in the example app when it is running on the Samsung A546B and the
Authenticatebutton is clicked multiple times very fast.This PR adds a check flag to prevent sending new permission requests if one is already requested.