Use potentially given missingEpicMultiplier to decrease max RCB in sandbox when loading from URL #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full disclosure, I never actually ran this, but I'm pretty certain it works as intended
So this is kind of a half-fix but it at least doesn't make anything worse, I think
So there was already a
missingEpicMultiplierwhich gets filled in on the smartass side when using "tweak this set in the sandbox", it just didn't actually get used on the sandbox side. This fixes that part, so using a link from smartass should now correctly decrease max RCB with your actual missing epic multiplier.The other thing that I found out doesn't actually work yet is that changing max RCB in sandbox just doesn't change the URL and therefore also doesn't get loaded if you use that URL elsewhere. I wanted to just quickly fix that as well (by adding similar logic to the
toProto()below), but its a bit annoying. Epic multiplier changes max RCB by 2 per tick, and is stored as an integer. This means if you put an odd number as your max RCB in sandbox, it cannot properly save it as a "missing epic multiplier". Next to that, you could of course end up with a missing epic multiplier larger than 100 if you simply do ((540 - rcb) / 2), which I guess is not a real issue, but still somewhat ugly.The true fix is probably to change
missingEpicMultiplierto just arcbfield or something like that, where you just straight up fill in the rcb value itself instead of the missing ER. However, this is not something I want to do just from github edits, and I also don't know anything about proto backwards compatibility :D