fix(web): recognise secure auth session cookies#829
Merged
simonjcarr merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
b9b746b to
a16ac47
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__Secure-, and__Host-session cookiesRoot cause
In HTTPS production-like runs, Better Auth can set a secure-prefixed session cookie such as
__Secure-better-auth.session_token. The login page asks Better Auth directly and treats that cookie as authenticated, redirecting/loginto/dashboard. The Next proxy only checkedbetter-auth.session_token, so it treated/dashboardas unauthenticated and redirected back to/login, causing a browser redirect loop.Validation
node --experimental-strip-types --test lib/auth/session-cookie-names.test.mjsnpm run lint -- proxy.ts lib/auth/session-cookie-names.ts lib/auth/session-cookie-names.test.mjsnpm run type-checkct-ops-web-local@browser-use:http://localhost:3000/dashboardloadsOverview | CT-Opsafter sign-in