combine interpreter checkpoint by mpernambuco · Pull Request #85 · cartesi/machine-solidity-step

mpernambuco · 2026-02-25T23:27:28Z

No description provided.

Copilot

Pull request overview

This PR updates the Solidity uarch interpreter/step implementation to align with a newer machine-emulator layout that introduces a shadow TLB region and checkpointing support, plus related constant and ECALL interface updates.

Changes:

Add TLB/checkpoint-related constants and extend uarch ECALL handling (halt/putchar/mark-dirty-page/write-TLB).
Introduce write4Words to efficiently write a full 32-byte leaf (used for TLB entry updates).
Update mock/test memory layout and CMIO RX buffer constant names to match the new address map.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/UArchInterpret.t.sol	Updates tests for new halt flag API and mock memory layout sizing.
templates/EmulatorConstants.sol.template	Adds TLB sizing + checkpoint address constants to template.
templates/AccessLogs.sol.template	Reorders prod/test sections and adds `write4Words`; updates mock memory layout to include shadow TLB.
src/UArchStep.sol	Adds new ECALL functions and uses new halt/cycle semantics.
src/SendCmioResponse.sol	Renames constants to updated address-map identifiers.
src/EmulatorConstants.sol	Regenerates constants and adds TLB/checkpoint constants.
src/EmulatorCompat.sol	Adds checkpoint hash helpers, changes halt flag API, and implements TLB ECALL write path.
src/AdvanceStatus.sol	New helper to interpret advance/yield status from HTIF tohost.
src/AccessLogs.sol	Adds `write4Words` and minor parameter naming cleanup in offset helpers.
shasum-download	Updates download checksums to match new emulator artifacts.
helper_scripts/generate_UArchStep.sh	Adjusts generator filtering/replacements for updated upstream C++ annotations/signatures.
helper_scripts/generate_SendCmioResponse.sh	Updates generator replacement for new RX buffer constants and hash-tree word size naming.
helper_scripts/generate_EmulatorConstants.lua	Extends constants generation for new address map / yield reasons / TLB config.
Makefile	Bumps referenced machine-emulator version for test data/log downloads.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

edubart · 2026-04-09T16:07:05Z

+
+        uint64 tohost =
+            EmulatorCompat.readWord(a, EmulatorConstants.HTIF_TOHOST_ADDRESS);
+        uint16 reason = uint16(tohost >> 32);


This hardcoded 32 should ideally use a constant to make it more clear.

edubart · 2026-04-09T16:39:26Z

@GCdePaula Can you take a look? You left some comments related with the changes at #81 and #83, and seems like they were all addressed already, is that correct? Any remaining concerns?

@stephenctw You originally wrote the checkpoint code, does everything look ok? Have in mind we need to change the checkpoint address from 0x7ffff000 to 0xfe0 in emulator v0.20.0 (emulator calls it CM_AR_SHADOW_REVERT_ROOT_HASH_START) and this will impact Dave.

@diegonehab Is the TLB changes related to the new ECALLs correct?

@mpernambuco Can you address my comments and update to the new emulator tag?

edubart · 2026-04-09T16:56:39Z

+
+    error InvalidReason(uint16 reason);
+
+    function advanceStatus(AccessLogs.Context memory a)


Personally I don't like how this advanceStatus was introduced in the repository without being used or tests, however I assume Dave is testing it somehow, so we don't need to delay this PR.

edubart · 2026-04-09T16:57:12Z

+    using Buffer for Buffer.Context;
    using Memory for uint64;

+    function getCheckpointHash(AccessLogs.Context memory a)


Personally I don't like how both getCheckpointHash/setCheckpointHash were introduced in the repository without being used or tests, however I assume Dave is testing it somehow, so we don't need to delay this PR.

I think these should be renamed to RevertRootHash to match the emulator.

@stephenctw can we rename this to match the emulator naming convention? I think revert root hash is much more informative than checkpoint hash.

This is being renamed by #88 which we will be merged after merging this PR first.

diegonehab · 2026-04-09T17:59:25Z

@GCdePaula Can you take a look? You left some comments related with the changes at #81 and #83, and seems like they were all addressed already, is that correct? Any remaining concerns?

@stephenctw You originally wrote the checkpoint code, does everything look ok? Have in mind we need to change the checkpoint address from 0x7ffff000 to 0xfe0 in emulator v0.20.0 (emulator calls it CM_AR_SHADOW_REVERT_ROOT_HASH_START) and this will impact Dave.

@diegonehab Is the TLB changes related to the new ECALLs correct?

@mpernambuco Can you address my comments and update to the new emulator tag?

Indeed. There is a mismatch.

GCdePaula · 2026-04-10T10:17:57Z

@GCdePaula Can you take a look? You left some comments related with the changes at #81 and #83, and seems like they were all addressed already, is that correct? Any remaining concerns?

No concerns related to #81 and #83!

github-project-automation Bot added this to Machine Unit Feb 25, 2026

github-project-automation Bot moved this to Todo in Machine Unit Feb 25, 2026

mpernambuco requested review from GCdePaula, mpolitzer and stephenctw February 25, 2026 23:39

mpernambuco changed the title ~~Refs/heads/combine interpreter checkpoint~~ combine interpreter checkpoint Feb 25, 2026

mpernambuco force-pushed the combine-interpreter-checkpoint branch from 33d63f0 to f66937e Compare February 26, 2026 14:46

edubart assigned mpernambuco Feb 26, 2026

mpolitzer mentioned this pull request Feb 27, 2026

make the prototype node work with the 0.20.0 emulator #84

Closed

mpolitzer previously approved these changes Mar 25, 2026

View reviewed changes

github-project-automation Bot moved this from Todo to Waiting Merge in Machine Unit Mar 25, 2026

mpolitzer requested a review from Copilot March 25, 2026 18:18

Copilot started reviewing on behalf of mpolitzer March 25, 2026 18:18 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread src/EmulatorCompat.sol

Comment thread templates/AccessLogs.sol.template

Comment thread src/EmulatorCompat.sol

Comment thread src/EmulatorCompat.sol

mpernambuco dismissed mpolitzer’s stale review via 6faa5ab March 31, 2026 15:23

mpernambuco force-pushed the combine-interpreter-checkpoint branch from f66937e to 6faa5ab Compare March 31, 2026 15:23

feat: combine interpreter and checkpoint

c9b255c

mpernambuco force-pushed the combine-interpreter-checkpoint branch from 6faa5ab to c9b255c Compare March 31, 2026 16:18

mpolitzer previously approved these changes Apr 2, 2026

View reviewed changes

edubart added the enhancement New feature or request label Apr 9, 2026

edubart added this to the v0.14.0 milestone Apr 9, 2026

edubart moved this from Waiting Merge to Waiting Review in Machine Unit Apr 9, 2026

edubart requested a review from Copilot April 9, 2026 13:01

Copilot started reviewing on behalf of edubart April 9, 2026 13:01 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread src/AdvanceStatus.sol

Comment thread src/AdvanceStatus.sol

edubart requested changes Apr 9, 2026

View reviewed changes

github-project-automation Bot moved this from Waiting Review to In Progress in Machine Unit Apr 9, 2026

This was referenced Apr 9, 2026

Add checkpoint primitives #81

Closed

feat: interpreter update #83

Closed

edubart requested a review from diegonehab April 9, 2026 16:39

edubart reviewed Apr 9, 2026

View reviewed changes

chore: update CHECKPOINT_ADDRESS to REVERT_ROOT_HASH_ADDRESS

b750f38

mpernambuco dismissed mpolitzer’s stale review via b750f38 April 9, 2026 17:58

Marcos Pernambuco Motta added 2 commits April 9, 2026 15:19

chore: update emulator tag

9d5ebcd

chore: code cleanup

1b8f9a8

edubart reviewed Apr 9, 2026

View reviewed changes

Comment thread Makefile Outdated

Marcos Pernambuco Motta added 2 commits April 9, 2026 17:10

chore: point to final emulator tag

b7ea28b

chore: update download shasum

d9429ac

edubart previously approved these changes Apr 9, 2026

View reviewed changes

github-project-automation Bot moved this from In Progress to Waiting Merge in Machine Unit Apr 9, 2026

stephenctw mentioned this pull request Apr 10, 2026

feat: update REVERT_ROOT_HASH_ADDRESS cartesi/dave#261

Open

chore: generate REVERT_ROOT_HASH_ADDRESS

fee663e

mpernambuco dismissed edubart’s stale review via fee663e April 10, 2026 11:52

edubart approved these changes Apr 10, 2026

View reviewed changes

edubart merged commit fee663e into main Apr 10, 2026
2 checks passed

github-project-automation Bot moved this from Waiting Merge to Done in Machine Unit Apr 10, 2026

edubart deleted the combine-interpreter-checkpoint branch April 13, 2026 13:38


		error InvalidReason(uint16 reason);

		function advanceStatus(AccessLogs.Context memory a)

Conversation

mpernambuco commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

edubart Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edubart commented Apr 9, 2026

Uh oh!

edubart Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

edubart Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

diegonehab Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

diegonehab Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

edubart Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

diegonehab commented Apr 9, 2026

Uh oh!

Uh oh!

GCdePaula commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants