chore(crm-agent): drop scripts/discover_fields.py (dead-weight + off-architecture)#64
Merged
Merged
Conversation
A one-shot Dataverse exploration tool (fetch one Opportunity + entity metadata) used during initial integration. Three reasons to drop it: 1. Redundant: skills/crm-opportunity/references/FIELD_REFERENCE.md is now the documented field contract — writable fields, types, OData operations, polymorphic customer binding. Re-discovering at script time is solving a problem we already solved with a documented artifact. 2. Off-architecture: the script still authenticates via ClientSecretCredential(AZURE_TENANT_ID/CLIENT_ID/CLIENT_SECRET), which pre-dates the OBO + WIF zero-secret model the rest of the project moved to (ADR 0001). Keeping it as-is implicitly endorses an env-var pattern we no longer want; rewriting it to fit current auth is just delaying its removal. 3. Nobody calls it. No imports, no CI step, no doc references — pure dead-weight after Slice 7's bundle refactor. If a future customer needs to enumerate fields against a different Dataverse instance, a 30-line equivalent is faster to write fresh than to maintain a drift-prone outlier. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the legacy one-shot Dataverse field-discovery script.
skills/crm-opportunity/references/FIELD_REFERENCE.md, which documents the writable Opportunity fields + OData cookbook as a stable contract.ClientSecretCredential(AZURE_TENANT_ID/CLIENT_ID/CLIENT_SECRET)from before the OBO + WIF zero-secret refactor (ADR 0001). Keeping it implicitly endorses an env-var pattern we no longer want.If a future customer needs to enumerate fields against a different Dataverse instance, rewriting a 30-line probe is faster than maintaining a drift-prone outlier.
Test plan
git grep discover_fieldsreturns nothing after the deletion🤖 Generated with Claude Code