FEAT: Initialize triangle from dict.#706
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
=======================================
Coverage 85.12% 85.13%
=======================================
Files 85 85
Lines 4909 4911 +2
Branches 629 630 +1
=======================================
+ Hits 4179 4181 +2
Misses 521 521
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
You are so fast @genedan, I was just about to work on this one😅 |
kennethshsu
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the initialization of a triangle via data supplied in a dictionary. Closes #701.
Note
Low Risk
Low risk: change is limited to accepting
dictinput by converting it to a pandasDataFrame, plus a unit test to confirm parity with existing DataFrame initialization.Overview
Trianglenow accepts a Pythondictfor thedataargument by converting it to a pandasDataFrameduring initialization.Adds a regression test (
test_triangle_init_from_dict) asserting a dict-backed triangle is equal to one built from an equivalent DataFrame, and updates the constructor docstring/type hints accordingly.Reviewed by Cursor Bugbot for commit 1b0a7a8. Bugbot is set up for automated code reviews on this repo. Configure here.