Update chapter_7.rst#754
Conversation
| (All) 1.164 1.056 1.027 1.012 1.005 1.003 1.002 1.001 1.0 | ||
|
|
||
| Now we can select a set of averages. | ||
| We will also fake some geometric averages. |
There was a problem hiding this comment.
Unprofessional "fake" language in published documentation text
Low Severity
The text We will also fake some geometric averages. reads as a personal draft note rather than polished documentation. The word "fake" is ambiguous — it's unclear whether the results are fabricated or if this is a placeholder for a real section.
Reviewed by Cursor Bugbot for commit 2b4f6fe. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## experimental #754 +/- ##
=============================================
Coverage 85.94% 85.94%
=============================================
Files 85 85
Lines 4924 4924
Branches 637 637
=============================================
Hits 4232 4232
Misses 491 491
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
There are 5 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 14f3b36. Configure here.


Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Mostly documentation/doctest expansion, but it adds a large amount of executable
doctestcontent that could break doc builds or become flaky if outputs change.Overview
Adds a new Friedland docs section to the JupyterBook TOC and updates the Friedland landing page title styling.
Greatly expands
docs/friedland/chapter_7.rstfrom a brief intro into a full, step-by-step (doctested) reproduction of Friedland Chapter 7 exhibits, including reported/paid development, multiple averaging methods (including geometric), explicit selected patterns withDevelopmentConstant+TailConstant, rounded CDF/ultimate calculations, and helper functions to generate summary/unpaid exhibits; Exhibit III is left as WIP.Reviewed by Cursor Bugbot for commit 7de6f5d. Bugbot is set up for automated code reviews on this repo. Configure here.