Skip to content

Update chapter_7.rst#754

Merged
henrydingliu merged 21 commits into
experimentalfrom
henrydingliu-patch-2
May 9, 2026
Merged

Update chapter_7.rst#754
henrydingliu merged 21 commits into
experimentalfrom
henrydingliu-patch-2

Conversation

@henrydingliu
Copy link
Copy Markdown
Collaborator

@henrydingliu henrydingliu commented May 9, 2026

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

  • I passed tests locally for both code (pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Medium Risk
Mostly documentation/doctest expansion, but it adds a large amount of executable doctest content that could break doc builds or become flaky if outputs change.

Overview
Adds a new Friedland docs section to the JupyterBook TOC and updates the Friedland landing page title styling.

Greatly expands docs/friedland/chapter_7.rst from a brief intro into a full, step-by-step (doctested) reproduction of Friedland Chapter 7 exhibits, including reported/paid development, multiple averaging methods (including geometric), explicit selected patterns with DevelopmentConstant + TailConstant, rounded CDF/ultimate calculations, and helper functions to generate summary/unpaid exhibits; Exhibit III is left as WIP.

Reviewed by Cursor Bugbot for commit 7de6f5d. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
(All) 1.164 1.056 1.027 1.012 1.005 1.003 1.002 1.001 1.0

Now we can select a set of averages.
We will also fake some geometric averages.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unprofessional "fake" language in published documentation text

Low Severity

The text We will also fake some geometric averages. reads as a personal draft note rather than polished documentation. The word "fake" is ambiguous — it's unclear whether the results are fabricated or if this is a placeholder for a real section.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2b4f6fe. Configure here.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.94%. Comparing base (b45d315) to head (7de6f5d).
⚠️ Report is 23 commits behind head on experimental.

Additional details and impacted files
@@              Coverage Diff              @@
##           experimental     #754   +/-   ##
=============================================
  Coverage         85.94%   85.94%           
=============================================
  Files                85       85           
  Lines              4924     4924           
  Branches            637      637           
=============================================
  Hits               4232     4232           
  Misses              491      491           
  Partials            201      201           
Flag Coverage Δ
unittests 85.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 4 potential issues.

There are 5 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 14f3b36. Configure here.

Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
Comment thread docs/friedland/chapter_7.rst Outdated
@henrydingliu henrydingliu merged commit 1cbe1f7 into experimental May 9, 2026
7 checks passed
@henrydingliu henrydingliu deleted the henrydingliu-patch-2 branch May 9, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant