#717#770
Merged
Merged
Conversation
…nctions to sparse.COO, and keep module-level functions to sp. Replaces xp() with xp.COO() to create sparse arrays when xp used to be callable and was used as a constructor.
Bumps [mistune](https://github.com/lepture/mistune) from 3.1.4 to 3.2.1. - [Release notes](https://github.com/lepture/mistune/releases) - [Changelog](https://github.com/lepture/mistune/blob/main/docs/changes.rst) - [Commits](lepture/mistune@v3.1.4...v3.2.1) --- updated-dependencies: - dependency-name: mistune dependency-version: 3.2.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Build(deps): Bump mistune from 3.1.4 to 3.2.1
Update pyproject.toml - Add numpy #738
Enhance docstrings and examples for improved clarity for many estimators
…nto 0.9.2-release-prep
Closes #757 The Adjustments section header in docs/library/api.md was a copy-paste of the Workflow section. The :mod: link and .. automodule:: directive both pointed at chainladder.workflow, so the rendered RTD page for Adjustments hyperlinked to the Workflow module page. The four classes listed under Adjustments (BootstrapODPSample, BerquistSherman, Trend, ParallelogramOLF) all live in chainladder.adjustments, which is the correct target. Co-authored-by: Nick Kinney <nkinney06@gmail.com>
…p() (#761) Per maintainer feedback on #758/#761: matplotlib is needed at runtime for TriangleDisplay.heatmap() even though it isn't imported directly, so it must remain a core dependency. Add an inline comment so future contributors don't try to move it again. Co-authored-by: Nick Kinney <nkinney06@gmail.com>
…nto 0.9.2-release-prep
REFACTOR: Reorganize type hierarchy of sparse.py. Move array-level fu…
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.6.3 to 2.7.0. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.6.3...2.7.0) --- updated-dependencies: - dependency-name: urllib3 dependency-version: 2.7.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Build(deps): Bump urllib3 from 2.6.3 to 2.7.0
…nto 0.9.2-release-prep
v.0.9.2 release notes
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c2c748c. Configure here.
| else: | ||
| w2 = w.copy() | ||
| w2 = sp(data=w2.data, coords=w2.coords, fill_value=sp.nan, shape=w2.shape) | ||
| w2 = sp.COO(data=w2.data, coords=w2.coords, fill_value=sp.nan, shape=w2.shape) |
There was a problem hiding this comment.
Incomplete refactor: sp.nan no longer exists
High Severity
The sparse module refactor changed sp from being the COO class to the sparse module. The old sp.nan attribute (set via sp.nan = np.array(...) when sp was COO) was correctly migrated to COO.nan, but weighted_regression.py still references sp.nan. Since the sparse module has no .nan attribute, this will raise an AttributeError at runtime when the OLS regression path is triggered with a sparse backend. All other files were updated to use sp.COO.nan or COO.nan.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c2c748c. Configure here.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Touches core sparse-backend construction paths (Triangle init, slicing, arithmetic prep) and changes dependency constraints, which could affect numerical behavior or backend compatibility despite being largely mechanical.
Overview
Updates sparse-array handling to consistently use
sparse.COO(andCOO.nan) instead of relying onsp(...)-style constructors, including Triangle initialization, sparse.loc/.atmutation, arithmetic coercion, and utility helpers.Refactors
chainladder.utils.sparseinto a lighter wrapper, adds targeted unit tests forarray,where, and in-placefloor, and bumps packaging metadata (version0.9.2, tighterpandasminimum, add explicitnumpydependency) alongside documentation/PR-template updates and expanded docstring examples for deterministic IBNR methods (Benktander/BF/CapeCod/ExpectedLoss) and API docs.Reviewed by Cursor Bugbot for commit c2c748c. Bugbot is set up for automated code reviews on this repo. Configure here.