fixing triangle.full_expectation_#883
Merged
henrydingliu merged 2 commits intoMay 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 32cf8e6. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## #882-full-exp #883 +/- ##
==============================================
Coverage 87.04% 87.05%
==============================================
Files 86 86
Lines 4986 4989 +3
Branches 646 647 +1
==============================================
+ Hits 4340 4343 +3
Misses 456 456
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Small property fix in reserve projection helpers with added regression tests; no auth, security, or external API surface changes.
Overview
Fixes
full_expectation_so cumulative vs incremental handling matchesfull_triangle_: it usesX_.is_cumulativewhen the fitted estimator hasX_, otherwiseself.is_cumulative. That correctsfull_expectation_onfit_predictoutputs (and similar objects) that are triangles without a separateX_.Tests now assert
full_expectation_fromfitvsfit_predictagree (cumulative and incremental), and numeric comparisons use the sharedatolfixture instead of hard-coded0.00001thresholds.Reviewed by Cursor Bugbot for commit 71a8348. Bugbot is set up for automated code reviews on this repo. Configure here.