sync#891
Merged
Merged
Conversation
Adds Sphinx doctest Examples sections to DevelopmentCorrelation and ValuationCorrelation. Each example opens with the Mack chain-ladder assumption being tested, prints the full decision signal (statistic, confidence band, and boolean) rather than a single boolean, and ties the result back to the chain-ladder workflow. Refs #704
Adds Sphinx doctest Examples section to the BootstrapODPSample class showing basic fit (resampled_triangles_.shape and scale_), downstream stochastic IBNR via Chainladder, and the effect of drop_high on scale_. Uses random_state=42 and n_sims=100 for deterministic, fast output. Refs #704
Rewords the paragraph introducing the drop_high=True example to describe it as a leave-one-out sensitivity check on the column maxima rather than outlier removal, since drop_high mechanically removes the column max without any outlier test. Addresses review feedback on #836.
Per @henrydingliu review on #844: opening paragraph now scoped to the calendar-effect concept; the per-diagonal vs whole-triangle distinction is introduced as a transition between the two testcode blocks. Refs #704
- Drop the jb build internals + duplicate warnings note (kennethshsu) - Rename 'tutorial notebooks' to 'onboarding and Quickstart notebooks' (kennethshsu) - Drop the 'What to edit for which part of the site' table and 'Known issues' section as redundant with the Source files table and #841 (kennethshsu)
…missing unit tests.
…stic values for changed options.
docs: add README documenting docs build sources and outputs
Improved docstring and added examples for Development class
[REFACTOR]: Remove repetitive code. Remove dead Python 3.8 code. Add …
…option getters and setters. Deprecate cl.array_backend() and cl.auto_sparse()
first batch of deliverables for friedland reconstruction
[REFACTOR]: Continue work on cl.__init__.py refactor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental #891 +/- ##
================================================
+ Coverage 86.94% 87.30% +0.36%
================================================
Files 86 86
Lines 4994 5114 +120
Branches 644 683 +39
================================================
+ Hits 4342 4465 +123
+ Misses 462 458 -4
- Partials 190 191 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related GitHub Issue(s)
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
Options API changes (removed DT64 options and deprecated helpers) could break callers still using old names; core valuation paths now depend on module-level datetime constants.
Overview
This PR refactors package configuration and expands documentation across the library and docs site.
chainladder.optionsis reworked from class-level settings into an instance-basedOptionsclass with validation, per-optionreset_option, and removal of deprecatedarray_backend/auto_sparsehelpers. Datetime precision is no longer exposed asDT64_DTYPE/DT64_UNIToptions; instead__dt64_dtype__and__dt64_unit__are module-level constants used in triangle valuation, pandas aggregation, anddate_delta_adjustmentfor Pandas 2/3 compatibility.Docstrings gain runnable examples and clearer parameter notes for
Development,BootstrapODPSample,DevelopmentCorrelation, andValuationCorrelation. Tests add coverage for options defaults/get/set/reset and refactor sample fixtures via a shared_sample_fixturethat sets/restoresARRAY_BACKEND.The docs add a contributor
docs/README.md, a Friedland section (chapters 6–7 RST, chapter 8 notebook, TOC entry), and a minorpyproject.tomlformatting tweak. CODEOWNERS is a newline-only change.Reviewed by Cursor Bugbot for commit caaff87. Bugbot is set up for automated code reviews on this repo. Configure here.